Skip to content

docs(skills): update upgrading-sdk-v2 with ActionError adoption and local CI validation#36

Merged
TheRealAgentK merged 2 commits intomasterfrom
docs/35/upgrade-skill-actionerror-validation
Apr 21, 2026
Merged

docs(skills): update upgrading-sdk-v2 with ActionError adoption and local CI validation#36
TheRealAgentK merged 2 commits intomasterfrom
docs/35/upgrade-skill-actionerror-validation

Conversation

@TheRealAgentK
Copy link
Copy Markdown
Collaborator

Summary

Updates the upgrading-sdk-v2 agent skill based on lessons learned from upgrading 6 integrations in Autohive-AI/autohive-integrations#258.

Closes #35

Changes

ActionError adoption (new section)

  • Documents SDK 1.1.0's ActionError as a required adoption during the 2.0.0 upgrade
  • Before/after examples for source code and test assertions
  • Clarifies ActionError is a dataclass (return, don't raise)

execute_action behavior change (new in Step 5C)

  • ValidationError is no longer raised — returns ResultType.VALIDATION_ERROR instead
  • Migration examples for pytest.raises(ValidationError) → result type check

Local CI validation (Step 7 rewrite)

  • Now a required step, not optional
  • Exact commands for: ruff with CI config, unit tests, integration tests, validate_integration.py, check_code.py
  • ⚠️ warning about --config ../autohive-integrations-tooling/ruff.toml (line-length=120 vs default 88)

CI fetch pattern linter caveat (new in Step 7E + Gotcha 7)

  • Documents the naive regex matcher that false-positives on variables named response when a helper already unwraps .data
  • Recommends renaming to gql_result, body, api_data

Expanded checklist

  • ActionError, ResultType imports, CI validation scripts

Agent skill for AI coding assistants (Amp, Claude Code) that automates
upgrading integrations from SDK 1.x to 2.0.0. Covers source code
(context.fetch → FetchResponse.data), test mock updates, requirements.txt,
and config.json version bump.

Includes skills/README.md with setup instructions for workspace-level
and global installation.
…ocal CI validation

- Document ActionError (SDK 1.1.0) adoption as part of the upgrade
- Document execute_action ValidationError → ResultType change
- Make local CI validation a required step with exact commands
- Add ruff config caveat (line-length=120 vs default 88)
- Add CI fetch pattern linter false-positive caveat
- Expand checklist and gotchas sections

Closes #35
@github-actions
Copy link
Copy Markdown

Coverage — 69e8b69 (docs(skills): update upgrading-sdk-v2 with ActionError adoption and local CI validation) by @TheRealAgentK

Total coverage: 100%

File Stmts Miss Cover Missing
src/autohive_integrations_sdk/__init__.py 2 0 100%
src/autohive_integrations_sdk/integration.py 358 0 100%

@TheRealAgentK TheRealAgentK merged commit 313077d into master Apr 21, 2026
1 check passed
@TheRealAgentK TheRealAgentK deleted the docs/35/upgrade-skill-actionerror-validation branch April 21, 2026 01:11
@TheRealAgentK
Copy link
Copy Markdown
Collaborator Author

Thx @ProRedCat - @NinosMan please have a look at the skill regardless - if there's comments and changes from your point of view, we can add them in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: update upgrading-sdk-v2 skill with ActionError adoption and local CI validation

2 participants